Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 12033083: Ensure that the active browser gets pushed into the correct browser list. (Closed)

Created:
7 years, 11 months ago by ananta
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Ensure that the active browser gets pushed into the correct browser list. In Chrome AURA there could be two browser lists active at any given time. The desktop and the ASH list. This ensures that the download shelf shows up when the save item is created in Chrome ASH on Windows 8. BUG=170483 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178697

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/browser_list.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
7 years, 11 months ago (2013-01-24 19:35:03 UTC) #1
sky
https://codereview.chromium.org/12033083/diff/1/chrome/browser/ui/views/frame/browser_frame.cc File chrome/browser/ui/views/frame/browser_frame.cc (right): https://codereview.chromium.org/12033083/diff/1/chrome/browser/ui/views/frame/browser_frame.cc#newcode151 chrome/browser/ui/views/frame/browser_frame.cc:151: chrome::BrowserListImpl* browser_list = Shouldn't BrowserList::SetActive do the right thing? ...
7 years, 11 months ago (2013-01-24 19:42:31 UTC) #2
ananta
https://codereview.chromium.org/12033083/diff/1/chrome/browser/ui/views/frame/browser_frame.cc File chrome/browser/ui/views/frame/browser_frame.cc (right): https://codereview.chromium.org/12033083/diff/1/chrome/browser/ui/views/frame/browser_frame.cc#newcode151 chrome/browser/ui/views/frame/browser_frame.cc:151: chrome::BrowserListImpl* browser_list = On 2013/01/24 19:42:31, sky wrote: > ...
7 years, 11 months ago (2013-01-24 21:21:06 UTC) #3
sky
7 years, 11 months ago (2013-01-24 22:30:52 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698