build/android/run_tests.py - Issue 12033066: [Android] Fix error in sharding of gtests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/run_tests.py

Issue 12033066: [Android] Fix error in sharding of gtests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed nit Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/run_tests.py

diff --git a/build/android/run_tests.py b/build/android/run_tests.py

index 5c80bf3a04ad1dfcd3bd6d787597f85311ea02c4..60fec67b60718721767d945ba2d7c3e8e1ce41e1 100755

--- a/build/android/run_tests.py

+++ b/build/android/run_tests.py

@@ -176,8 +176,8 @@ class TestSharder(BaseTestSharder):

A SingleTestRunner object.

"""

device_num = len(self.attached_devices)

- shard_size = (len(self.tests) + device_num - 1) / device_num

- shard_test_list = self.tests[index * shard_size : (index + 1) * shard_size]

+ shard_test_list = [self.tests[i::device_num]

+ for i in xrange(device_num)][index]

Isaac (away) 2013/01/24 00:01:03 Would shard_test_list = self.tests[index::device_

frankf 2013/01/24 00:19:12 Done.

test_filter = ':'.join(shard_test_list) + self.gtest_filter

return SingleTestRunner(

device,

« no previous file with comments | « no previous file | no next file » | no next file with comments »