Issue 12033066: [Android] Fix error in sharding of gtests.

Issue 12033066: [Android] Fix error in sharding of gtests. (Closed)

Created:
7 years, 11 months ago by frankf

Modified:
7 years, 11 months ago

Reviewers:
craigdh, klundberg, Isaac (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Fix error in sharding of gtests. The formula for splitting tests into |device_num| shards has always been incorrect. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178462

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed nit #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	build/android/run_tests.py	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

klundberg

lgtm once you have fixed line length :-) https://codereview.chromium.org/12033066/diff/1/build/android/run_tests.py File build/android/run_tests.py (right): https://codereview.chromium.org/12033066/diff/1/build/android/run_tests.py#newcode179 build/android/run_tests.py:179: shard_test_list ...

7 years, 11 months ago (2013-01-23 23:39:42 UTC) #2

frankf

Done. On 2013/01/23 23:39:42, klundberg wrote: > lgtm once you have fixed line length :-) ...

7 years, 11 months ago (2013-01-23 23:41:57 UTC) #3

Isaac (away)

https://codereview.chromium.org/12033066/diff/5001/build/android/run_tests.py File build/android/run_tests.py (right): https://codereview.chromium.org/12033066/diff/5001/build/android/run_tests.py#newcode180 build/android/run_tests.py:180: for i in xrange(device_num)][index] Would shard_test_list = self.tests[index::device_num] also ...

7 years, 11 months ago (2013-01-24 00:01:03 UTC) #5

craigdh

On 2013/01/24 00:01:03, Isaac wrote: > https://codereview.chromium.org/12033066/diff/5001/build/android/run_tests.py > File build/android/run_tests.py (right): > > https://codereview.chromium.org/12033066/diff/5001/build/android/run_tests.py#newcode180 > ...

7 years, 11 months ago (2013-01-24 00:05:57 UTC) #6

frankf

7 years, 11 months ago (2013-01-24 00:19:12 UTC) #7

https://codereview.chromium.org/12033066/diff/5001/build/android/run_tests.py
File build/android/run_tests.py (right):

https://codereview.chromium.org/12033066/diff/5001/build/android/run_tests.py...
build/android/run_tests.py:180: for i in xrange(device_num)][index]
On 2013/01/24 00:01:03, Isaac wrote:
> Would
> 
> shard_test_list = self.tests[index::device_num]
> 
> also work?

Done.

Expand Messages | Collapse Messages