Issue 12033063: - Fix simarm/simmips builds on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12033063: - Fix simarm/simmips builds on Mac. (Closed)

Created:
7 years, 11 months ago by Ivan Posva

Modified:
7 years, 11 months ago

Reviewers:
regis, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Fix simarm/simmips builds on Mac. Committed: https://code.google.com/p/dart/source/detail?r=17505

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -9 lines)			Patch
M	runtime/tools/gyp/runtime-configurations.gypi	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	tools/gyp/configurations.gypi	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	tools/gyp/configurations_make.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gyp/configurations_xcode.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

TBR to unbreak folks... -Ivan https://codereview.chromium.org/12033063/diff/1/runtime/tools/gyp/runtime-configurations.gypi File runtime/tools/gyp/runtime-configurations.gypi (left): https://codereview.chromium.org/12033063/diff/1/runtime/tools/gyp/runtime-configurations.gypi#oldcode91 runtime/tools/gyp/runtime-configurations.gypi:91: 'GCC_OPTIMIZATION_LEVEL': '3', This line ...

7 years, 11 months ago (2013-01-23 22:15:28 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages