src/mksnapshot.cc - Issue 12033011: Add Isolate parameter to Persistent class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mksnapshot.cc

Issue 12033011: Add Isolate parameter to Persistent class. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Added explicit Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mksnapshot.cc

diff --git a/src/mksnapshot.cc b/src/mksnapshot.cc

index d7775517b7d26b20bb37fc8d109bacb212c878f5..a3665e969df2db02ddcedf2de3e06a2aa4797efa 100644

--- a/src/mksnapshot.cc

+++ b/src/mksnapshot.cc

@@ -384,7 +384,7 @@ int main(int argc, char** argv) {

// context even after we have disposed of the context.

HEAP->CollectAllGarbage(i::Heap::kNoGCFlags, "mksnapshot");

i::Object* raw_context = *(v8::Utils::OpenHandle(*context));

- context.Dispose();

+ context.Dispose(context->GetIsolate());

CppByteSink sink(argv[1]);

// This results in a somewhat smaller snapshot, probably because it gets rid

// of some things that are cached between garbage collections.

« no previous file with comments | « src/handles.cc ('k') | src/profile-generator.h » ('j') | no next file with comments »