Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1928)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 12033003: Deferred (aka lazy) loading of static functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Missing imports Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index 2577ea3d5f66460a9100477213db51929a2303b8..0deb16c9afe49b61bfa099a194452b380071a953 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -61,6 +61,7 @@ class CodeEmitterTask extends CompilerTask {
NativeEmitter nativeEmitter;
CodeBuffer boundClosureBuffer;
CodeBuffer mainBuffer;
+ final CodeBuffer deferredBuffer = new CodeBuffer();
/** Shorter access to [isolatePropertiesName]. Both here in the code, as
well as in the generated code. */
String isolateProperties;
@@ -1712,6 +1713,11 @@ class CodeEmitterTask extends CompilerTask {
}
for (ClassElement element in sortedClasses) {
+ if (isDeferred(element)) {
+ warnNotImplemented(
+ element,
+ 'Warning: deferred loading of classes is not implemented yet.');
+ }
generateClass(element, buffer);
}
@@ -1740,7 +1746,7 @@ class CodeEmitterTask extends CompilerTask {
buffer.add('$N$n');
}
- void emitStaticFunctions(CodeBuffer buffer) {
+ void emitStaticFunctions(CodeBuffer eagerBuffer) {
bool isStaticFunction(Element element) =>
!element.isInstanceMember() && !element.isField();
@@ -1752,6 +1758,7 @@ class CodeEmitterTask extends CompilerTask {
.toSet();
for (Element element in Elements.sortedByPosition(elements)) {
+ CodeBuffer buffer = isDeferred(element) ? deferredBuffer : eagerBuffer;
jsAst.Expression code = backend.generatedCode[element];
emitStaticFunction(buffer, namer.getName(element), code);
jsAst.Expression bailoutCode = backend.generatedBailoutCode[element];
@@ -1764,6 +1771,7 @@ class CodeEmitterTask extends CompilerTask {
// Is it possible the primary function was inlined but the bailout was not?
for (Element element in
Elements.sortedByPosition(pendingElementsWithBailouts)) {
+ CodeBuffer buffer = isDeferred(element) ? deferredBuffer : eagerBuffer;
jsAst.Expression bailoutCode = backend.generatedBailoutCode[element];
emitStaticFunction(buffer, namer.getBailoutName(element), bailoutCode);
}
@@ -1774,6 +1782,8 @@ class CodeEmitterTask extends CompilerTask {
compiler.codegenWorld.staticFunctionsNeedingGetter;
for (FunctionElement element in
Elements.sortedByPosition(functionsNeedingGetter)) {
+ // TODO(ahe): Defer loading of these getters.
ngeoffray 2013/02/19 10:04:57 warnNotImplemented?
ahe 2013/02/19 11:10:36 The overhead is small, and I can't give a location
+
// The static function does not have the correct name. Since
// [addParameterStubs] use the name to create its stubs we simply
// create a fake element with the correct name.
@@ -2615,13 +2625,15 @@ if (typeof document !== 'undefined' && document.readyState !== 'complete') {
emitInitFunction(mainBuffer);
compiler.assembledCode = mainBuffer.getText();
- if (generateSourceMap) {
- SourceFile compiledFile = new SourceFile(null, compiler.assembledCode);
- String sourceMap = buildSourceMap(mainBuffer, compiledFile);
- compiler.outputProvider('', 'js.map')
- ..add(sourceMap)
+ if (!deferredBuffer.isEmpty) {
+ String code = deferredBuffer.getText();
+ compiler.outputProvider('part', 'js')
+ ..add(code)
..close();
+ outputSourceMap(deferredBuffer, compiler.assembledCode, 'part');
}
+
+ outputSourceMap(mainBuffer, compiler.assembledCode, '');
});
return compiler.assembledCode;
}
@@ -2631,6 +2643,26 @@ if (typeof document !== 'undefined' && document.readyState !== 'complete') {
buffer.forEachSourceLocation(sourceMapBuilder.addMapping);
return sourceMapBuilder.build(compiledFile);
}
+
+ void outputSourceMap(CodeBuffer buffer, String code, String name) {
+ if (!generateSourceMap) return;
+ SourceFile compiledFile = new SourceFile(null, compiler.assembledCode);
+ String sourceMap = buildSourceMap(mainBuffer, compiledFile);
+ compiler.outputProvider(name, 'js.map')
+ ..add(sourceMap)
+ ..close();
+ }
+
+ bool isDeferred(Element element) {
+ return compiler.deferredLoadTask.isDeferred(element);
+ }
+
+ // TODO(ahe): Remove this when deferred loading is fully implemented.
+ void warnNotImplemented(Element element, String message) {
+ compiler.reportMessage(compiler.spanFromSpannable(element),
+ MessageKind.GENERIC.error({'text': message}),
+ api.Diagnostic.WARNING);
+ }
}
const String GENERATED_BY = """

Powered by Google App Engine
This is Rietveld 408576698