Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 12033003: Deferred (aka lazy) loading of static functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
index 67085fdb8a719521baf050b245c134aff2505a0b..fcf7294dfb67f1e5bdae7a05dde785f089eadd9d 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
@@ -1063,6 +1063,10 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
Selector selector,
Link<Node> arguments,
Node currentNode) {
+ // TODO(ahe): What's the harm in inlining from a lazily loaded
kasperl 2013/02/05 08:30:53 Good question. I guess you still want the code to
ahe 2013/02/05 13:54:22 Good point.
+ // library? It makes testing harder, but is it what the user
+ // wants?
+ if (compiler.deferredLoadTask.isDeferred(element)) return false;
if (compiler.disableInlining) return false;
// Ensure that [element] is an implementation element.
element = element.implementation;

Powered by Google App Engine
This is Rietveld 408576698