Issue 1203253002: Add support for line-height in TextStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1203253002: Add support for line-height in TextStyle. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
eseidel

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add support for line-height in TextStyle. Also, some minor cleanup in TextStyle to make it more readable. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7cb48839010046dcbdccda488a59e3d9d6a4d5e0

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -53 lines)			Patch
M	sky/examples/widgets/styled_text.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	sky/sdk/lib/painting/text_style.dart	View	9 chunks	+17 lines, -36 lines	0 comments	Download
M	sky/tests/examples/styled_text-expected.txt	View	8 chunks	+15 lines, -15 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-24 20:25:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7cb48839010046dcbdccda488a59e3d9d6a4d5e0 (presubmit successful).