Issue 120323002: Revert 242158 "Refactor CastSocket code for the following:"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 120323002: Revert 242158 "Refactor CastSocket code for the following:" (Closed)

Created:
7 years ago by Dan Beam

Modified:
7 years ago

Reviewers:
Munjal (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 242158 "Refactor CastSocket code for the following:" Broke Win compile: 231>C:\b\build\slave\Win\build\src\chrome/browser/extensions/api/cast_channel/cast_socket.h(19): fatalerror C1083: Cannot open include file: 'chrome/browser/extensions/api/cast_channel/cast_channel.pb.h': No such file or directory > Refactor CastSocket code for the following: > - Refactor the Write code to avoid recursion > - Refactor the read code to avoid recursion > - With read code refactored, hook it up appropriately with connection flow > to avoid re-entrancy of DoConnectLoop > > Review URL: https://codereview.chromium.org/79673003 TBR=munjal@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242199

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+749 lines, -1125 lines)			Patch
M	trunk/src/chrome/browser/extensions/api/cast_channel/cast_message_util.cc	View	2 chunks	+20 lines, -23 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/cast_channel/cast_socket.h	View	11 chunks	+75 lines, -114 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/cast_channel/cast_socket.cc	View	14 chunks	+212 lines, -313 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/cast_channel/cast_socket_unittest.cc	View	10 chunks	+442 lines, -675 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r242199.

Expand Messages | Collapse Messages