Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3886)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 1203223003: Replace return button with close button on custom tab toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: get resource from intent data provider Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
index ba05df4b3f979a8639964bf08028f4018bcbd112..acc75e1e240f792b19fa72224d8734648fc2eb7c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -132,10 +132,12 @@ public class CustomTabActivity extends ChromeActivity {
mToolbarManager = new ToolbarManager(this, controlContainer,
mAppMenuHandler, mAppMenuPropertiesDelegate,
getCompositorViewHolder().getInvalidator());
+ mToolbarManager.setCloseButtonIcon(mIntentDataProvider.getCloseButtonIconRes());
mToolbarManager.setShowTitle(mIntentDataProvider.getTitleVisibilityState()
== CustomTabIntentDataProvider.CUSTOM_TAB_SHOW_PAGE_TITLE);
mToolbarManager.updatePrimaryColor(mIntentDataProvider.getToolbarColor());
setStatusBarColor(mIntentDataProvider.getToolbarColor());
+
Yusuf 2015/06/29 23:05:58 extra line
Ian Wen 2015/06/29 23:56:00 Done.
if (mIntentDataProvider.shouldShowActionButton()) {
mToolbarManager.addCustomActionButton(mIntentDataProvider.getActionButtonIcon(),
new OnClickListener() {

Powered by Google App Engine
This is Rietveld 408576698