chrome/android/java/res/layout/custom_tabs_toolbar.xml - Issue 1203223003: Replace return button with close button on custom tab toolbar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 1203223003: Replace return button with close button on custom tab toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/btn_chevron_left.png ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java » ('j') | chrome/android/java_staging/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/custom_tabs_toolbar.xml

diff --git a/chrome/android/java/res/layout/custom_tabs_toolbar.xml b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

index 5f117bee6a98987d42780a2958cc2f20215775fe..b5e4191d7e84c0b43a19e9b9e7a738ab10df1b64 100644

--- a/chrome/android/java/res/layout/custom_tabs_toolbar.xml

+++ b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

@@ -5,10 +5,10 @@

<org.chromium.chrome.browser.toolbar.CustomTabToolbar xmlns:android="http://schemas.android.com/apk/res/android">

<org.chromium.chrome.browser.widget.TintedImageButton

- android:id="@+id/back_button"

+ android:id="@+id/close_button"

style="@style/ToolbarButton"

android:layout_gravity="center_vertical"

- android:src="@drawable/btn_chevron_left" />

+ android:src="@drawable/btn_close" />

Yusuf 2015/06/24 21:23:36 in the bug it mentions we would like to give a cho

Ian Wen 2015/06/29 22:07:24 Added an intent extra in the next patch.

<ImageButton android:id="@+id/security_button"

style="@style/LocationBarButton"

android:layout_width="@dimen/location_bar_icon_width"