Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1203193002: Add loopSKP flag to nanobench (Closed)

Created:
5 years, 6 months ago by Chris Dalton
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add loopSKP flag to nanobench Adds a loopSKP flag that forces SKPBenches to draw with only 1 loop. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b4022965a280dd1ed64d6103dd29e2189abe6e00

Patch Set 1 #

Patch Set 2 : force to 1 loop for cpu_bench as well #

Patch Set 3 : make SKPAnimation change simpler #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M bench/Benchmark.h View 1 chunk +4 lines, -0 lines 0 comments Download
M bench/SKPAnimationBench.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/SKPAnimationBench.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M bench/SKPBench.h View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M bench/SKPBench.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M bench/nanobench.cpp View 1 2 6 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Chris Dalton
Hey guys, just curious if you'd be OK with something like this. It also ended ...
5 years, 6 months ago (2015-06-24 18:47:44 UTC) #2
bsalomon
lgtm
5 years, 6 months ago (2015-06-25 15:50:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203193002/60001
5 years, 6 months ago (2015-06-25 17:46:07 UTC) #6
commit-bot: I haz the power
The author cdalton@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-25 17:46:08 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 17:52:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/b4022965a280dd1ed64d6103dd29e2189abe6e00

Powered by Google App Engine
This is Rietveld 408576698