Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1203183003: WebUI: Fix radio and checkbox behavior when text selected. (Closed)

Created:
5 years, 6 months ago by tommycli
Modified:
5 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, oshima+watch_chromium.org, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Fix radio and checkbox behavior when text selected. Previously, when text or a link was selected, clicking on the label portion of a radio or checkbox would not work. This fixes that by applying the -webkit-user-select: none; to the whole label instead of just the text portion of it. Why this works? Who knows. But it does work. BUG=497669 TEST=MANUAL Committed: https://crrev.com/bc37351bca408ebd2006823b46fb0ca691afd74e Cr-Commit-Position: refs/heads/master@{#336695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/webui/resources/css/widgets.css View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
tommycli
dbeam: PTAL
5 years, 6 months ago (2015-06-24 23:25:05 UTC) #2
tommycli
estade: PTAL See bug. We discovered -webkit-user-select misbehaves when only applied to a sub-element of ...
5 years, 6 months ago (2015-06-24 23:43:44 UTC) #4
tommycli
estade: ping
5 years, 6 months ago (2015-06-26 17:38:14 UTC) #5
tommycli
On 2015/06/26 17:38:14, tommycli wrote: > estade: ping hi estade: ping
5 years, 5 months ago (2015-06-29 19:45:52 UTC) #6
Evan Stade
lgtm
5 years, 5 months ago (2015-06-29 23:16:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203183003/1
5 years, 5 months ago (2015-06-29 23:18:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 00:29:59 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 00:30:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc37351bca408ebd2006823b46fb0ca691afd74e
Cr-Commit-Position: refs/heads/master@{#336695}

Powered by Google App Engine
This is Rietveld 408576698