Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1203143004: Make it possible to run Sky apps offline (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make it possible to run Sky apps offline This CL makes it possible to run Sky apps offline by introducing new DartLibraryProvider subclasses, specifically one that can load directly from the file system. A future CL will expand this functionality to work with asset bundles as well. Currently, the only platform that uses this functionality is Linux, which can now load a simple Sky app without even loading a network stack. Making this work on other platforms is work for future CLs. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/94abe1042d044b9399fff43bba7c6e4ca575f1f2

Patch Set 1 #

Patch Set 2 : gn check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+577 lines, -281 lines) Patch
M sky/engine/core/core.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/script/dart_controller.h View 3 chunks +7 lines, -5 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 6 chunks +21 lines, -36 lines 0 comments Download
D sky/engine/core/script/dart_library_provider_network.h View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/engine/core/script/dart_library_provider_network.cc View 1 chunk +0 lines, -84 lines 0 comments Download
A sky/engine/core/script/dart_library_provider_webview.h View 1 chunk +35 lines, -0 lines 0 comments Download
A + sky/engine/core/script/dart_library_provider_webview.cc View 3 chunks +11 lines, -29 lines 0 comments Download
M sky/engine/core/script/dom_dart_state.h View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/script/dom_dart_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/platform/WebString.h View 4 chunks +5 lines, -9 lines 0 comments Download
M sky/engine/public/sky/BUILD.gn View 1 1 chunk +3 lines, -1 line 0 comments Download
M sky/engine/public/sky/sky_view.h View 3 chunks +13 lines, -6 lines 0 comments Download
M sky/engine/public/sky/sky_view.cc View 3 chunks +34 lines, -35 lines 0 comments Download
M sky/engine/tonic/dart_library_provider.h View 1 chunk +5 lines, -4 lines 0 comments Download
M sky/services/viewport/viewport_observer.mojom View 1 chunk +4 lines, -1 line 0 comments Download
M sky/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java View 1 chunk +1 line, -1 line 0 comments Download
A sky/shell/dart/BUILD.gn View 1 1 chunk +24 lines, -0 lines 0 comments Download
A sky/shell/dart/dart_library_provider_files.h View 1 chunk +36 lines, -0 lines 0 comments Download
A sky/shell/dart/dart_library_provider_files.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A sky/shell/dart/dart_library_provider_network.h View 1 chunk +41 lines, -0 lines 0 comments Download
A sky/shell/dart/dart_library_provider_network.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M sky/shell/ios/sky_surface.mm View 1 chunk +1 line, -1 line 0 comments Download
M sky/shell/linux/main.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M sky/shell/ui/engine.h View 2 chunks +10 lines, -1 line 0 comments Download
M sky/shell/ui/engine.cc View 3 chunks +42 lines, -12 lines 0 comments Download
M sky/viewer/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A sky/viewer/dart_library_provider_impl.h View 1 chunk +38 lines, -0 lines 0 comments Download
A sky/viewer/dart_library_provider_impl.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M sky/viewer/document_view.h View 3 chunks +3 lines, -1 line 0 comments Download
M sky/viewer/document_view.cc View 3 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-25 06:36:53 UTC) #1
abarth-chromium
5 years, 6 months ago (2015-06-25 20:59:27 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
94abe1042d044b9399fff43bba7c6e4ca575f1f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698