Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: Source/core/html/parser/HTMLResourcePreloader.cpp

Issue 1203143002: Do not preload data URIs. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added TODO and layout test case Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/http/tests/loading/preload-image-src-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All Rights Reserved. 2 * Copyright (C) 2013 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 void HTMLResourcePreloader::preload(PassOwnPtr<PreloadRequest> preload) 70 void HTMLResourcePreloader::preload(PassOwnPtr<PreloadRequest> preload)
71 { 71 {
72 if (preload->isPreconnect()) { 72 if (preload->isPreconnect()) {
73 preconnectHost(preload.get()); 73 preconnectHost(preload.get());
74 return; 74 return;
75 } 75 }
76 // TODO(yoichio): Should preload if document is imported. 76 // TODO(yoichio): Should preload if document is imported.
77 if (!m_document->loader()) 77 if (!m_document->loader())
78 return; 78 return;
79 FetchRequest request = preload->resourceRequest(m_document); 79 FetchRequest request = preload->resourceRequest(m_document);
80 // TODO(dgozman): This check should go to HTMLPreloadScanner, but this requi res
81 // making Document::completeURLWithOverride logic to be statically accessibl e.
82 if (request.url().protocolIsData())
83 return;
80 if (preload->resourceType() == Resource::Script || preload->resourceType() = = Resource::CSSStyleSheet || preload->resourceType() == Resource::ImportResource ) 84 if (preload->resourceType() == Resource::Script || preload->resourceType() = = Resource::CSSStyleSheet || preload->resourceType() == Resource::ImportResource )
81 request.setCharset(preload->charset().isEmpty() ? m_document->charset(). string() : preload->charset()); 85 request.setCharset(preload->charset().isEmpty() ? m_document->charset(). string() : preload->charset());
82 request.setForPreload(true); 86 request.setForPreload(true);
83 Platform::current()->histogramCustomCounts("WebCore.PreloadDelayMs", static_ cast<int>(1000 * (monotonicallyIncreasingTime() - preload->discoveryTime())), 0, 2000, 20); 87 Platform::current()->histogramCustomCounts("WebCore.PreloadDelayMs", static_ cast<int>(1000 * (monotonicallyIncreasingTime() - preload->discoveryTime())), 0, 2000, 20);
84 m_document->loader()->startPreload(preload->resourceType(), request); 88 m_document->loader()->startPreload(preload->resourceType(), request);
85 } 89 }
86 90
87 } // namespace blink 91 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/http/tests/loading/preload-image-src-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698