DevTools: never iterate over css source data and cssom rules in the same loop.

DevTools: never iterate over css source data and cssom rules in the same loop.

R=lushnikov
BUG=178410
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197835

[lushnikov, 2015-06-25 15:33:08]

lgtm

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
File Source/core/inspector/InspectorStyleSheet.cpp (right):

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.cpp:910:
RefPtrWillBeRawPtr<CSSRuleSourceData>
InspectorStyleSheet::ruleAfterSourceRange(const SourceRange& sourceRange)
ruleAfterSourceRange is a confusing name given its return type.
Lets have ::ruleSourceDataAfterSourceRange

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.cpp:922: CSSStyleRule*
InspectorStyleSheet::insertCSSOMRuleInStyleSheet(CSSRule* insertBefore, const
String& ruleText, ExceptionState& exceptionState)
isn't insertBefore a CSSStyleRule actually?

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.cpp:929: }
let's ASSERT(!insertBefore || index < length())

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.cpp:942: CSSStyleRule*
InspectorStyleSheet::insertCSSOMRuleInMediaRule(CSSMediaRule* mediaRule,
CSSRule* insertBefore, const String& ruleText, ExceptionState& exceptionState)
ditto about insertBefore type

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.cpp:949: }
ditto

[pfeldman, 2015-06-25 16:10:36]

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
File Source/core/inspector/InspectorStyleSheet.cpp (right):

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.cpp:910:
RefPtrWillBeRawPtr<CSSRuleSourceData>
InspectorStyleSheet::ruleAfterSourceRange(const SourceRange& sourceRange)
On 2015/06/25 15:33:08, lushnikov wrote:
> ruleAfterSourceRange is a confusing name given its return type.
> Lets have ::ruleSourceDataAfterSourceRange

Acknowledged.

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.cpp:922: CSSStyleRule*
InspectorStyleSheet::insertCSSOMRuleInStyleSheet(CSSRule* insertBefore, const
String& ruleText, ExceptionState& exceptionState)
On 2015/06/25 15:33:08, lushnikov wrote:
> isn't insertBefore a CSSStyleRule actually?

This can me a media rule.

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.cpp:929: }
On 2015/06/25 15:33:07, lushnikov wrote:
> let's ASSERT(!insertBefore || index < length())

It can happen when inserting into media rule or upon CSSOM operation.

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.cpp:942: CSSStyleRule*
InspectorStyleSheet::insertCSSOMRuleInMediaRule(CSSMediaRule* mediaRule,
CSSRule* insertBefore, const String& ruleText, ExceptionState& exceptionState)
On 2015/06/25 15:33:08, lushnikov wrote:
> ditto about insertBefore type

Acknowledged.

https://codereview.chromium.org/1203133002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorStyleSheet.cpp:949: }
On 2015/06/25 15:33:07, lushnikov wrote:
> ditto

Acknowledged.

[pfeldman, 2015-06-25 16:10:43]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2015-06-25 16:11:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1203133002/20001

[commit-bot: I haz the power, 2015-06-25 17:11:48]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197835