Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 120313003: Include the default implementation of WebThemeEngine.h in webthemeengine_impl_android.h (Closed)

Created:
7 years ago by Dirk Pranke
Modified:
6 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Include the default implementation of WebThemeEngine.h in webthemeengine_impl_android.h Rather than using the (now-obsolete) version in platform/android. Once this lands, we can delete the android stub. R=jamesr@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webkit/child/webthemeengine_impl_android.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Dirk Pranke
7 years ago (2013-12-21 01:48:55 UTC) #1
jamesr
lgtm
7 years ago (2013-12-21 01:59:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/120313003/1
7 years ago (2013-12-21 02:02:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=239474
7 years ago (2013-12-21 04:26:47 UTC) #4
Dirk Pranke
Wow, I totally thought this had landed ... trying again.
6 years, 11 months ago (2014-01-17 17:39:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/120313003/1
6 years, 11 months ago (2014-01-17 17:39:38 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 19:48:43 UTC) #7
Message was sent while issue was closed.
Change committed as 245589

Powered by Google App Engine
This is Rietveld 408576698