chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc - Issue 120313002: Use stub GL draw/clear calls for browser tests that do not need pixels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc

Issue 120313002: Use stub GL draw/clear calls for browser tests that do not need pixels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: stubgl: use_osmesa Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc ('k') | chrome/browser/extensions/cast_streaming_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc

diff --git a/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc b/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc

index be080ab3503e4a71bcbac1fb5067ca8051f5ed14..46e2a4090676e6b19f244e131bbc3531639675e1 100644

--- a/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc

+++ b/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc

@@ -99,6 +99,12 @@ class TabCapturePerformanceTest

return suffix;

}

+ virtual void SetUp() OVERRIDE {

+ // These tests needs pixel results.

+ UseRealGLContexts();

+ ExtensionApiTest::SetUp();

+ }

virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {

if (!ScalingMethod().empty()) {

command_line->AppendSwitchASCII(switches::kTabCaptureUpscaleQuality,

@@ -125,8 +131,6 @@ class TabCapturePerformanceTest

command_line->AppendSwitchASCII(switches::kWindowSize, "2000,1500");

}

- UseRealGLContexts();

if (!HasFlag(kUseGpu)) {

command_line->AppendSwitch(switches::kDisableGpu);

} else {