Use stub GL draw/clear calls for browser tests that do not need pixels.

content/public/test/browser_test_base.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/browser_test_base.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/stack_trace.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 102 matching lines @@
  private:
   virtual ~LocalHostResolverProc() {}
 };
 
 }  // namespace
 
 extern int BrowserMain(const MainFunctionParams&);
 
 BrowserTestBase::BrowserTestBase()
     : allow_test_contexts_(true),
-      allow_osmesa_(true),
       use_software_compositing_(false) {
 #if defined(OS_MACOSX)
   base::mac::SetOverrideAmIBundled(true);
   base::PowerMonitorDeviceSource::AllocateSystemIOPorts();
 #endif
 
 #if defined(OS_POSIX)
   handle_sigterm_ = true;
 #endif
 
@@ skipping 35 matching lines @@
   if (base::SysInfo::IsRunningOnChromeOS())
     allow_test_contexts_ = false;
 #endif
 
 #if defined(USE_AURA)
   if (command_line->HasSwitch(switches::kDisableTestCompositor))
     allow_test_contexts_  = false;
 
   // Use test contexts for browser tests unless they override and force us to
   // use a real context.
-  if (allow_test_contexts_ && !use_software_compositing_) {
-    content::ImageTransportFactory::InitializeForUnitTests(
-        scoped_ptr<ui::ContextFactory>(new ui::TestContextFactory));
-  }
+  if (allow_test_contexts_ && !use_software_compositing_)
+    command_line->AppendSwitch(switches::kDisableGLDrawingForTests);
 #endif
 
-  // When using real GL contexts, we usually use OSMesa as this works on all
-  // bots. The command line can override this behaviour to use a real GPU.
+  bool use_osmesa = true;
+
+  // We usually use OSMesa as this works on all bots. The command line can
+  // override this behaviour to use hardware GL.
   if (command_line->HasSwitch(switches::kUseGpuInTests))
-    allow_osmesa_ = false;
+    use_osmesa = false;
 
-  // Some bots pass this flag when they want to use a real GPU.
+  // Some bots pass this flag when they want to use hardware GL.
   if (command_line->HasSwitch("enable-gpu"))
-    allow_osmesa_ = false;
+    use_osmesa = false;
 
 #if defined(OS_MACOSX)
-  // On Mac we always use a real GPU.
-  allow_osmesa_ = false;
+  // On Mac we always use hardware GL.
+  use_osmesa = false;
 #endif
 
 #if defined(OS_ANDROID)
-  // On Android we always use a real GPU.
-  allow_osmesa_ = false;
+  // On Android we always use hardware GL.
+  use_osmesa = false;
 #endif
 
 #if defined(OS_CHROMEOS)
   // If the test is running on the chromeos envrionment (such as
-  // device or vm bots), the compositor will use real GL contexts, and
-  // we should use real GL bindings with it.
+  // device or vm bots), we use hardware GL.
   if (base::SysInfo::IsRunningOnChromeOS())
-    allow_osmesa_ = false;
+    use_osmesa = false;
 #endif
 
   if (command_line->HasSwitch(switches::kUseGL)) {
     NOTREACHED() <<
         "kUseGL should not be used with tests. Try kUseGpuInTests instead.";
   }
 
-  if (allow_osmesa_ && !use_software_compositing_) {
+  if (use_osmesa && !use_software_compositing_) {
     command_line->AppendSwitchASCII(
         switches::kUseGL, gfx::kGLImplementationOSMesaName);
   }
 
   scoped_refptr<net::HostResolverProc> local_resolver =
       new LocalHostResolverProc();
   rule_based_resolver_ =
       new net::RuleBasedHostResolverProc(local_resolver.get());
   rule_based_resolver_->AddSimulatedFailure("wpad");
   net::ScopedDefaultHostResolverProc scoped_local_host_resolver_proc(
@@ skipping 51 matching lines @@
   CHECK(renderer_loop);
 
   renderer_loop->PostTask(
       FROM_HERE,
       base::Bind(&RunTaskOnRendererThread, task, runner->QuitClosure()));
   runner->Run();
 }
 
 void BrowserTestBase::UseRealGLContexts() { allow_test_contexts_ = false; }
 
-void BrowserTestBase::UseRealGLBindings() {
-  DCHECK(!use_software_compositing_)
-      << "Can't use GL with software compositing";
-  allow_osmesa_ = false;
-}
-
 void BrowserTestBase::UseSoftwareCompositing() {
 #if !defined(USE_AURA) && !defined(OS_MACOSX)
   // TODO(danakj): Remove when GTK linux is no more.
   NOTREACHED();
 #endif
-
-  DCHECK(allow_osmesa_) << "Can't use GL with software compositing";
   use_software_compositing_ = true;
 }
 
 bool BrowserTestBase::UsingOSMesa() const {
   CommandLine* cmd = CommandLine::ForCurrentProcess();
   return cmd->GetSwitchValueASCII(switches::kUseGL) ==
          gfx::kGLImplementationOSMesaName;
 }
 
 }  // namespace content