Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Side by Side Diff: src/arm/frames-arm.h

Issue 1203103003: Unify the stack layout for construct frames (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix deopt case and clean up constants Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/builtins-arm.cc ('k') | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ARM_FRAMES_ARM_H_ 5 #ifndef V8_ARM_FRAMES_ARM_H_
6 #define V8_ARM_FRAMES_ARM_H_ 6 #define V8_ARM_FRAMES_ARM_H_
7 7
8 namespace v8 { 8 namespace v8 {
9 namespace internal { 9 namespace internal {
10 10
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 static const int kLengthOffset = StandardFrameConstants::kExpressionsOffset; 134 static const int kLengthOffset = StandardFrameConstants::kExpressionsOffset;
135 135
136 static const int kFrameSize = 136 static const int kFrameSize =
137 StandardFrameConstants::kFixedFrameSize + kPointerSize; 137 StandardFrameConstants::kFixedFrameSize + kPointerSize;
138 }; 138 };
139 139
140 140
141 class ConstructFrameConstants : public AllStatic { 141 class ConstructFrameConstants : public AllStatic {
142 public: 142 public:
143 // FP-relative. 143 // FP-relative.
144 static const int kImplicitReceiverOffset = -6 * kPointerSize; 144 static const int kImplicitReceiverOffset = -5 * kPointerSize;
145 static const int kConstructorOffset = -5 * kPointerSize;
146 static const int kLengthOffset = -4 * kPointerSize; 145 static const int kLengthOffset = -4 * kPointerSize;
147 static const int kCodeOffset = StandardFrameConstants::kExpressionsOffset; 146 static const int kCodeOffset = StandardFrameConstants::kExpressionsOffset;
148 147
149 static const int kFrameSize = 148 static const int kFrameSize =
150 StandardFrameConstants::kFixedFrameSize + 4 * kPointerSize; 149 StandardFrameConstants::kFixedFrameSize + 3 * kPointerSize;
151 }; 150 };
152 151
153 152
154 class InternalFrameConstants : public AllStatic { 153 class InternalFrameConstants : public AllStatic {
155 public: 154 public:
156 // FP-relative. 155 // FP-relative.
157 static const int kCodeOffset = StandardFrameConstants::kExpressionsOffset; 156 static const int kCodeOffset = StandardFrameConstants::kExpressionsOffset;
158 }; 157 };
159 158
160 159
161 inline Object* JavaScriptFrame::function_slot_object() const { 160 inline Object* JavaScriptFrame::function_slot_object() const {
162 const int offset = JavaScriptFrameConstants::kFunctionOffset; 161 const int offset = JavaScriptFrameConstants::kFunctionOffset;
163 return Memory::Object_at(fp() + offset); 162 return Memory::Object_at(fp() + offset);
164 } 163 }
165 164
166 165
167 } } // namespace v8::internal 166 } } // namespace v8::internal
168 167
169 #endif // V8_ARM_FRAMES_ARM_H_ 168 #endif // V8_ARM_FRAMES_ARM_H_
OLDNEW
« no previous file with comments | « src/arm/builtins-arm.cc ('k') | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698