Compile pdf_browsertest.cc in non-official builds too.

chrome/browser/ui/pdf/pdf_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/files/file.h"
 #include "base/files/file_enumerator.h"
 #include "base/hash.h"
 #include "base/path_service.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 13 matching lines @@
 #include "content/public/test/browser_test_utils.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/clipboard/clipboard.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/screen.h"
 
 using content::NavigationController;
 using content::WebContents;
 
+// Note: All tests in here require the internal PDF plugin, so they're disabled
+// in non-official builds. We still compile them though, to prevent bitrot.
+
 namespace {
 
 // Include things like browser frame and scrollbar and make sure we're bigger
 // than the test pdf document.
 static const int kBrowserWidth = 1000;
 static const int kBrowserHeight = 600;
 
 class PDFBrowserTest : public InProcessBrowserTest,
                        public testing::WithParamInterface<int>,
                        public content::NotificationObserver {
@@ skipping 161 matching lines @@
   // The filename of the bitmap to compare the snapshot to.
   std::string expected_filename_;
   // If the snapshot is different, holds the location where it's saved.
   base::FilePath snapshot_filename_;
   // How many times we've seen chrome::LOAD_STOP.
   int load_stop_notification_count_;
 
   net::test_server::EmbeddedTestServer pdf_test_server_;
 };
 
-#if defined(OS_CHROMEOS)
+#if !defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS)
 // TODO(sanjeevr): http://crbug.com/79837

[Lei Zhang, 2014/01/07 19:58:37]

Would you mind changing the TODO to me since Sanjeev no longer works on
Chromium? Please make it obvious the TODO is for CrOS only. Ditto below.

[Bernhard Bauer, 2014/01/08 09:33:24]

Done.

 #define MAYBE_Basic DISABLED_Basic
 #else
 #define MAYBE_Basic Basic
 #endif
 // Tests basic PDF rendering.  This can be broken depending on bad merges with
 // the vendor, so it's important that we have basic sanity checking.
 IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_Basic) {
   ASSERT_NO_FATAL_FAILURE(Load());
   ASSERT_NO_FATAL_FAILURE(WaitForResponse());
   // OS X uses CoreText, and FreeType renders slightly different on Linux and
   // Win.
 #if defined(OS_MACOSX)
   // The bots render differently than locally, see http://crbug.com/142531.
   ASSERT_TRUE(VerifySnapshot("pdf_browsertest_mac.png") ||
               VerifySnapshot("pdf_browsertest_mac2.png"));
 #elif defined(OS_LINUX)
   ASSERT_TRUE(VerifySnapshot("pdf_browsertest_linux.png"));
 #else
   ASSERT_TRUE(VerifySnapshot("pdf_browsertest.png"));
 #endif
 }
 
-#if defined(OS_CHROMEOS)
+#if !defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS)
 // TODO(sanjeevr): http://crbug.com/79837
 #define MAYBE_Scroll DISABLED_Scroll
 #else
 #define MAYBE_Scroll Scroll
 #endif
 // Tests that scrolling works.
 IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_Scroll) {
   ASSERT_NO_FATAL_FAILURE(Load());
 
   // We use wheel mouse event since that's the only one we can easily push to
   // the renderer.  There's no way to push a cross-platform keyboard event at
   // the moment.
   blink::WebMouseWheelEvent wheel_event;
   wheel_event.type = blink::WebInputEvent::MouseWheel;
   wheel_event.deltaY = -200;
   wheel_event.wheelTicksY = -2;
   WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   web_contents->GetRenderViewHost()->ForwardWheelEvent(wheel_event);
   ASSERT_NO_FATAL_FAILURE(WaitForResponse());
 
   int y_offset = 0;
   ASSERT_TRUE(content::ExecuteScriptAndExtractInt(
       browser()->tab_strip_model()->GetActiveWebContents(),
       "window.domAutomationController.send(plugin.pageYOffset())",
       &y_offset));
   ASSERT_GT(y_offset, 0);
 }
 
-#if defined(OS_CHROMEOS)
+#if !defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS)
 // TODO(sanjeevr): http://crbug.com/79837
 #define MAYBE_FindAndCopy DISABLED_FindAndCopy
 #else
 #define MAYBE_FindAndCopy FindAndCopy
 #endif
 IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_FindAndCopy) {
   ASSERT_NO_FATAL_FAILURE(Load());
   // Verifies that find in page works.
   ASSERT_EQ(3, ui_test_utils::FindInPage(
       browser()->tab_strip_model()->GetActiveWebContents(),
@@ skipping 17 matching lines @@
   clipboard->ReadAsciiText(ui::CLIPBOARD_TYPE_COPY_PASTE, &text);
   ASSERT_EQ("adipiscing", text);
 }
 
 const int kLoadingNumberOfParts = 10;
 
 // Tests that loading async pdfs works correctly (i.e. document fully loads).
 // This also loads all documents that used to crash, to ensure we don't have
 // regressions.
 // If it flakes, reopen http://crbug.com/74548.
-IN_PROC_BROWSER_TEST_P(PDFBrowserTest, Loading) {
+#if !defined(GOOGLE_CHROME_BUILD)
+#define MAYBE_Loading DISABLED_Loading
+#else
+#define MAYBE_Loading Loading
+#endif
+IN_PROC_BROWSER_TEST_P(PDFBrowserTest, MAYBE_Loading) {
   ASSERT_TRUE(pdf_test_server()->InitializeAndWaitUntilReady());
 
   NavigationController* controller =
       &(browser()->tab_strip_model()->GetActiveWebContents()->GetController());
   content::NotificationRegistrar registrar;
   registrar.Add(this,
                 content::NOTIFICATION_LOAD_STOP,
                 content::Source<NavigationController>(controller));
   std::string base_url = std::string("/");
 
@@ skipping 45 matching lines @@
       content::WaitForLoadStop(
           browser()->tab_strip_model()->GetActiveWebContents());
     }
   }
 }
 
 INSTANTIATE_TEST_CASE_P(PDFTestFiles,
                         PDFBrowserTest,
                         testing::Range(0, kLoadingNumberOfParts));
 
-#if defined(GOOGLE_CHROME_BUILD) && defined(OS_MACOSX)
+#if !defined(GOOGLE_CHROME_BUILD) || defined(OS_MACOSX)
 // http://crbug.com/315160
 #define MAYBE_Action DISABLED_Action
 #else
 #define MAYBE_Action Action
 #endif
 IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_Action) {
   ASSERT_NO_FATAL_FAILURE(Load());
 
   ASSERT_TRUE(content::ExecuteScript(
       browser()->tab_strip_model()->GetActiveWebContents(),
@@ skipping 34 matching lines @@
       browser()->tab_strip_model()->GetActiveWebContents(),
       "reloadPDF();"));
   observer.Wait();
 
   ASSERT_EQ("success",
             browser()->tab_strip_model()->GetActiveWebContents()->
                 GetURL().query());
 }
 
 }  // namespace