components/storage_monitor/test_storage_monitor.cc - Issue 120303003: [StorageMonitor] Move gallery name generation to StorageInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/storage_monitor/test_storage_monitor.cc

Issue 120303003: [StorageMonitor] Move gallery name generation to StorageInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unittest build error on mac/linux/chromeos Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/storage_monitor/storage_monitor_win_unittest.cc ('k') | components/storage_monitor/test_volume_mount_watcher_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/storage_monitor/test_storage_monitor.cc

diff --git a/components/storage_monitor/test_storage_monitor.cc b/components/storage_monitor/test_storage_monitor.cc

index 34cca9be6d3bea2d2eb50afeb3c44bcd1082a8be..fb5cc57b1b92f899e1b0b97c971feb456e2af8b5 100644

--- a/components/storage_monitor/test_storage_monitor.cc

+++ b/components/storage_monitor/test_storage_monitor.cc

@@ -87,8 +87,8 @@ bool TestStorageMonitor::GetStorageInfoForPath(

std::string device_id = StorageInfo::MakeDeviceId(

StorageInfo::FIXED_MASS_STORAGE, path.AsUTF8Unsafe());

*device_info =

- StorageInfo(device_id, path.BaseName().LossyDisplayName(), path.value(),

- base::string16(), base::string16(), base::string16(), 0);

+ StorageInfo(device_id, path.value(), base::string16(), base::string16(),

+ base::string16(), 0);

return true;

}