components/storage_monitor/storage_monitor_linux_unittest.cc - Issue 120303003: [StorageMonitor] Move gallery name generation to StorageInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/storage_monitor/storage_monitor_linux_unittest.cc

Issue 120303003: [StorageMonitor] Move gallery name generation to StorageInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address vandebo's comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/storage_monitor/storage_info.cc ('K') | « components/storage_monitor/storage_monitor_linux.cc ('k') | components/storage_monitor/storage_monitor_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/storage_monitor/storage_monitor_linux_unittest.cc

diff --git a/components/storage_monitor/storage_monitor_linux_unittest.cc b/components/storage_monitor/storage_monitor_linux_unittest.cc

index 7949ae0495ef2c5f9c89f9dddf717fdd20fa6c37..27a10edcffba8e9d95283dd9c9c8a7221a2f4ec3 100644

--- a/components/storage_monitor/storage_monitor_linux_unittest.cc

+++ b/components/storage_monitor/storage_monitor_linux_unittest.cc

@@ -88,7 +88,6 @@ scoped_ptr<StorageInfo> GetDeviceInfo(const base::FilePath& device_path,

StorageInfo::Type type = kTestDeviceData[i].type;

storage_info.reset(new StorageInfo(

StorageInfo::MakeDeviceId(type, kTestDeviceData[i].unique_id),

- base::string16(),

mount_point.value(),

base::ASCIIToUTF16("volume label"),

base::ASCIIToUTF16("vendor name"),