components/storage_monitor/portable_device_watcher_win.cc - Issue 120303003: [StorageMonitor] Move gallery name generation to StorageInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/storage_monitor/portable_device_watcher_win.cc

Issue 120303003: [StorageMonitor] Move gallery name generation to StorageInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/storage_monitor/media_transfer_protocol_device_observer_linux.cc ('K') | « components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc ('k') | components/storage_monitor/storage_info.h » ('j') | components/storage_monitor/storage_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/storage_monitor/portable_device_watcher_win.cc

diff --git a/components/storage_monitor/portable_device_watcher_win.cc b/components/storage_monitor/portable_device_watcher_win.cc

index 571bdaf89f78e77c435f7abf1ef6de07b67809fd..38e3b2f699815272d55c2d2b6eadd2e929da4ad7 100644

--- a/components/storage_monitor/portable_device_watcher_win.cc

+++ b/components/storage_monitor/portable_device_watcher_win.cc

@@ -635,8 +635,8 @@ void PortableDeviceWatcherWin::OnDidHandleDeviceAttachEvent(

// partition identifier to the storage name. E.g.: "Nexus 7 (s10001)"

base::string16 storage_name(name + L" (" +

vandebo (ex-Chrome) 2014/03/03 19:58:31 Should storage_name be passed as the model? It's

Haojian Wu 2014/03/04 05:00:12 Sounds fine. Done.

storage_iter->object_temporary_id + L')');

- StorageInfo info(storage_id, storage_name, location,

- storage_name, base::string16(), base::string16(), 0);

+ StorageInfo info(storage_id, location, storage_name, base::string16(),

+ base::string16(), 0);

storage_map_[storage_id] = info;

if (storage_notifications_) {

info.set_location(GetStoragePathFromStorageId(storage_id));