Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 120303002: Compile expat for PNaCl (Closed)

Created:
7 years ago by Sergey Ulanov
Modified:
6 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Compile expat for PNaCl Added expat_nacl target that compiles expat for PNaCl BUG=276739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243765

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : renamed to expat_nacl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
A third_party/expat/expat_nacl.gyp View 1 2 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sergey Ulanov
7 years ago (2013-12-20 23:10:40 UTC) #1
Sergey Ulanov
brettw: ping
6 years, 11 months ago (2014-01-08 21:54:37 UTC) #2
brettw
lgtm https://codereview.chromium.org/120303002/diff/1/third_party/expat/expat_untrusted.gyp File third_party/expat/expat_untrusted.gyp (right): https://codereview.chromium.org/120303002/diff/1/third_party/expat/expat_untrusted.gyp#newcode1 third_party/expat/expat_untrusted.gyp:1: # Copyright (c) 2012 The Chromium Authors. All ...
6 years, 11 months ago (2014-01-08 22:43:05 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/120303002/diff/1/third_party/expat/expat_untrusted.gyp File third_party/expat/expat_untrusted.gyp (right): https://codereview.chromium.org/120303002/diff/1/third_party/expat/expat_untrusted.gyp#newcode1 third_party/expat/expat_untrusted.gyp:1: # Copyright (c) 2012 The Chromium Authors. All rights ...
6 years, 11 months ago (2014-01-08 22:45:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/120303002/60001
6 years, 11 months ago (2014-01-08 22:47:11 UTC) #5
Sergey Ulanov
Renamed the new target to expat_nacl, per discussion in nacl-eng list.
6 years, 11 months ago (2014-01-08 23:55:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/120303002/320001
6 years, 11 months ago (2014-01-09 00:02:11 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 04:28:50 UTC) #8
Message was sent while issue was closed.
Change committed as 243765

Powered by Google App Engine
This is Rietveld 408576698