Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1203023002: Run input_method_bridge_unittest on Mac, remove unused DummyInputMethodDelegate (Closed)

Created:
5 years, 6 months ago by tapted
Modified:
5 years, 6 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run input_method_bridge_unittest on Mac, remove unused DummyInputMethodDelegate A recent refactor means that aura::client::kRootWindowInputMethodKey is no longer used for the test. So, to run it on Mac, it's just a matter of using the platform-independent types provided by WidgetTest. After this CL, DummyInputMethodDelegate would be unused, so it is deleted. BUG=378134

Patch Set 1 #

Patch Set 2 : unused includes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -73 lines) Patch
M ui/base/ime/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/base/ime/dummy_input_method_delegate.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/base/ime/dummy_input_method_delegate.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M ui/base/ime/ui_base_ime.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/ime/input_method_bridge_unittest.cc View 1 1 chunk +11 lines, -18 lines 1 comment Download
M ui/views/views.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
tapted
shuchen: please take a look Thanks! https://codereview.chromium.org/1203023002/diff/20001/ui/views/ime/input_method_bridge_unittest.cc File ui/views/ime/input_method_bridge_unittest.cc (left): https://codereview.chromium.org/1203023002/diff/20001/ui/views/ime/input_method_bridge_unittest.cc#oldcode21 ui/views/ime/input_method_bridge_unittest.cc:21: ui::InputMethodMinimal input_method(&input_method_delegate); http://crrev.com/333698 ...
5 years, 6 months ago (2015-06-24 05:24:22 UTC) #3
tapted
shuchen: ping?
5 years, 6 months ago (2015-06-24 23:33:04 UTC) #4
Shu Chen
On 2015/06/24 23:33:04, tapted wrote: > shuchen: ping? Sorry for late reply. InputMethodBridge will soon ...
5 years, 6 months ago (2015-06-25 00:57:42 UTC) #5
tapted
On 2015/06/25 00:57:42, Shu Chen wrote: > On 2015/06/24 23:33:04, tapted wrote: > > shuchen: ...
5 years, 6 months ago (2015-06-25 01:10:30 UTC) #6
Shu Chen
5 years, 6 months ago (2015-06-25 01:15:57 UTC) #7
Message was sent while issue was closed.
On 2015/06/25 01:10:30, tapted wrote:
> On 2015/06/25 00:57:42, Shu Chen wrote:
> > On 2015/06/24 23:33:04, tapted wrote:
> > > shuchen: ping?
> > 
> > Sorry for late reply.
> > 
> > InputMethodBridge will soon be gone. Please see
> > https://codereview.chromium.org/1177503003.
> 
> Nice!
> 
> I'll close this. Note you can probably also remove
dummy_input_method_delegate.*
> after https://codereview.chromium.org/1177503003 lands too.

Noted, thanks!

Powered by Google App Engine
This is Rietveld 408576698