Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1202973003: Expand ToBoolean stub so it can handle more types. (Closed)

Created:
5 years, 6 months ago by bbudge
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Expand ToBoolean stub so it can handle more types. SIMD values will require their own type code for conversion to boolean. LOG=N BUG=v8:4124 Committed: https://crrev.com/b7f4981c161c4aeaa8da9ceb01a0fdba94b21490 Cr-Commit-Position: refs/heads/master@{#29247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M src/code-stubs.h View 3 chunks +9 lines, -10 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
bbudge
5 years, 6 months ago (2015-06-24 04:59:42 UTC) #2
bbudge
5 years, 6 months ago (2015-06-24 05:00:14 UTC) #3
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-24 06:08:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202973003/1
5 years, 6 months ago (2015-06-24 06:08:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 06:10:51 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 06:11:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7f4981c161c4aeaa8da9ceb01a0fdba94b21490
Cr-Commit-Position: refs/heads/master@{#29247}

Powered by Google App Engine
This is Rietveld 408576698