chrome/browser/media/router/presentation_service_delegate_impl.cc - Issue 1202963004: Gets presentation ID from route ID upon route creation, and overrides previous presentation ID with…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.cc

Issue 1202963004: Gets presentation ID from route ID upon route creation, and overrides previous presentation ID with… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/media_router_mojo_impl.cc ('k') | content/browser/presentation/presentation_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_service_delegate_impl.cc

diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.cc b/chrome/browser/media/router/presentation_service_delegate_impl.cc

index 46649aed7be80842b89ef346c02aaf776d9f0145..d49c6f1c36fb13b74b5310bc8a68fd5255499e4d 100644

--- a/chrome/browser/media/router/presentation_service_delegate_impl.cc

+++ b/chrome/browser/media/router/presentation_service_delegate_impl.cc

@@ -666,9 +666,8 @@ void PresentationServiceDelegateImpl::OnRouteCreated(const MediaRoute& route) {

if (!main_frame)

return;

RenderFrameHostId render_frame_host_id(GetRenderFrameHostId(main_frame));

- // TODO(imcheng): Pass in valid default presentation ID once it is

- // available from MediaRoute URN. BUG=493365

- std::string presentation_id;

+ std::string presentation_id =

+ GetPresentationIdAndUrl(route.media_route_id()).first;

frame_manager_->OnPresentationSessionStarted(

render_frame_host_id, true,

content::PresentationSessionInfo(PresentationUrlFromMediaSource(source),

« no previous file with comments | « chrome/browser/media/router/media_router_mojo_impl.cc ('k') | content/browser/presentation/presentation_service_impl.cc » ('j') | no next file with comments »