Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3679)

Unified Diff: chrome/browser/media/router/create_session_request_unittest.cc

Issue 1202963004: Gets presentation ID from route ID upon route creation, and overrides previous presentation ID with… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/router/create_session_request.cc ('k') | chrome/browser/media/router/media_route.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/create_session_request_unittest.cc
diff --git a/chrome/browser/media/router/create_session_request_unittest.cc b/chrome/browser/media/router/create_session_request_unittest.cc
index 8e8590bea5b20a8a9943be0ee85801fa3835524b..322beaccbc062acf9495a2a065132b216088f61a 100644
--- a/chrome/browser/media/router/create_session_request_unittest.cc
+++ b/chrome/browser/media/router/create_session_request_unittest.cc
@@ -12,8 +12,10 @@ namespace media_router {
namespace {
-const char kPresentationUrl[] = "http://fooUrl";
+const char kPresentationUrl[] = "http://foo.com";
const char kPresentationId[] = "presentationId";
+const char kRouteId[] =
+ "urn:x-org.chromium:media:route:presentationId/cast-sink1/http://foo.com";
} // namespace
@@ -79,7 +81,7 @@ TEST_F(CreateSessionRequestTest, SuccessCallback) {
session_info),
base::Bind(&CreateSessionRequestTest::FailOnError,
base::Unretained(this)));
- context.MaybeInvokeSuccessCallback("routeid");
+ context.MaybeInvokeSuccessCallback(kRouteId);
// No-op since success callback is already invoked.
context.MaybeInvokeErrorCallback(content::PresentationError(
content::PRESENTATION_ERROR_NO_AVAILABLE_SCREENS, "Error message"));
@@ -101,7 +103,7 @@ TEST_F(CreateSessionRequestTest, ErrorCallback) {
error));
context.MaybeInvokeErrorCallback(error);
// No-op since error callback is already invoked.
- context.MaybeInvokeSuccessCallback("routeid");
+ context.MaybeInvokeSuccessCallback(kRouteId);
EXPECT_TRUE(cb_invoked_);
}
« no previous file with comments | « chrome/browser/media/router/create_session_request.cc ('k') | chrome/browser/media/router/media_route.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698