Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(92)

Issue 1202863003: Use EditingTestBase for VisibleSelectionTest (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
yoichio
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use EditingTestBase for VisibleSelectionTest This CL changes TextIteratorTest to inherit EditingTestBase to reduce duplicated code. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -41 lines) Patch
M Source/core/editing/VisibleSelectionTest.cpp View 3 chunks +2 lines, -41 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-25 04:57:42 UTC) #2
yoichio
lgtm
4 years, 10 months ago (2015-06-25 05:33:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202863003/1
4 years, 10 months ago (2015-06-25 09:01:09 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 09:07:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197802

Powered by Google App Engine
This is Rietveld 408576698