pkg/analysis_server/test/performance/instrumentation_input_converter.dart - Issue 1202843010: performance measurement: generate report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/performance/instrumentation_input_converter.dart

Issue 1202843010: performance measurement: generate report (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/performance/input_converter.dart ('k') | pkg/analysis_server/test/performance/log_file_input_converter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/performance/instrumentation_input_converter.dart

diff --git a/pkg/analysis_server/test/performance/instrumentation_input_converter.dart b/pkg/analysis_server/test/performance/instrumentation_input_converter.dart

index b0f9c6185eec9cde7d744b5616da338dce1defd8..32974c2333a5d71e2c458bc5b932f72a5c434c37 100644

--- a/pkg/analysis_server/test/performance/instrumentation_input_converter.dart

+++ b/pkg/analysis_server/test/performance/instrumentation_input_converter.dart

@@ -65,8 +65,7 @@ class InstrumentationInputConverter extends CommonInputConverter {

return convertRequest(decodeJson(line, fields[2]));

} else if (opCode == InstrumentationService.TAG_RESPONSE) {

// 1434096937454:Res:{"id"::"0","result"::{"version"::"1.7.0"}}

- recordResponse(decodeJson(line, fields[2]));

- return null;

+ return convertResponse(decodeJson(line, fields[2]));

} else if (opCode == InstrumentationService.TAG_ANALYSIS_TASK) {

// 1434096943208:Task:/Users/

return null;