Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(82)

Issue 1202843007: Use EditingTestBase for TextIteratorTest (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use EditingTestBase for TextIteratorTest This CL changes TextIteratorTest to inherit EditingTestBase to reduce duplicated code. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -73 lines) Patch
M Source/core/editing/iterators/TextIteratorTest.cpp View 29 chunks +27 lines, -73 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hajimehoshi
PTAL
4 years, 10 months ago (2015-06-24 10:15:00 UTC) #2
yosin_UTC9
lgtm Thanks!
4 years, 10 months ago (2015-06-25 03:46:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202843007/1
4 years, 10 months ago (2015-06-25 03:46:28 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 04:54:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197798

Powered by Google App Engine
This is Rietveld 408576698