Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1202843006: Fix -Werror=sign-compare error with GCC (Closed)

Created:
5 years, 6 months ago by wingo
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix -Werror=sign-compare error with GCC R=jkummerow@chromium.org LOG=N BUG= Committed: https://crrev.com/a9558715394e38afa299843404f3f45fbf950205 Cr-Commit-Position: refs/heads/master@{#29253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/frames.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
wingo
5 years, 6 months ago (2015-06-24 09:46:06 UTC) #1
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-24 11:13:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202843006/1
5 years, 6 months ago (2015-06-24 11:47:57 UTC) #4
wingo
On 2015/06/24 11:47:57, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 6 months ago (2015-06-24 11:51:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202843006/1
5 years, 6 months ago (2015-06-24 11:52:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 12:23:32 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 12:23:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9558715394e38afa299843404f3f45fbf950205
Cr-Commit-Position: refs/heads/master@{#29253}

Powered by Google App Engine
This is Rietveld 408576698