Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1202773002: Prevent scientific notation in LayoutUnit gdb prettyprinter. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
Reviewers:
cbiesinger, Dirk Pranke
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Prevent scientific notation in LayoutUnit gdb prettyprinter. Prevent this by increasing precision on the %g format specifier. Now we can see full values like 33554431.984375px, instead of having them crippled like 3.35544e+07px. R=cbiesinger@chromium.org,dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Tools/gdb/webkit.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-06-23 19:38:32 UTC) #1
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-23 19:41:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202773002/1
5 years, 6 months ago (2015-06-23 19:46:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60396)
5 years, 6 months ago (2015-06-23 21:49:48 UTC) #6
cbiesinger
lgtm
5 years, 6 months ago (2015-06-23 22:10:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202773002/1
5 years, 6 months ago (2015-06-23 22:11:13 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 23:27:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197682

Powered by Google App Engine
This is Rietveld 408576698