Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(100)

Issue 1202763005: Scroll only visual viewport during OSX pinch gesture behind flag. (Closed)

Created:
4 years, 10 months ago by bokan
Modified:
4 years, 10 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Scroll only visual viewport during OSX pinch gesture behind flag. This is part of the experiment to modify the viewport scroll order in some situations. Namely, during a pinch-zoom gesture, only the visual viewport should scroll. The path altered in this patch is used for OSX trackpad pinch-zoom. Touchscreen pinch-zoom on other platforms is handled in the compositor. This patch matches the behavior on the CC side for touchscreen pinch-zooms. BUG=443724 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197855

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -5 lines) Patch
M Source/core/frame/PinchViewport.cpp View 1 1 chunk +8 lines, -5 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202763005/20001
4 years, 10 months ago (2015-06-24 15:53:49 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-24 17:54:22 UTC) #4
bokan
ptal
4 years, 10 months ago (2015-06-25 13:25:55 UTC) #6
Rick Byers
lgtm
4 years, 10 months ago (2015-06-25 17:08:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202763005/20001
4 years, 10 months ago (2015-06-25 17:15:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/68335)
4 years, 10 months ago (2015-06-25 19:53:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202763005/20001
4 years, 10 months ago (2015-06-25 19:54:54 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 20:47:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197855

Powered by Google App Engine
This is Rietveld 408576698