Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 120273002: Revert 242121 "Reland "Add a HistogramRecorder class and use cas..." (Closed)

Created:
7 years ago by groby-ooo-7-16
Modified:
7 years ago
Reviewers:
lpromero
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 242121 "Reland "Add a HistogramRecorder class and use cas..." As per request from lpromero, reverting since it might be failing a test - see http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Tests%20%28tsan%29/builds/17153/steps/memory%20test%3A%20base_unittests/logs/stdio [ RUN ] HistogramTest.BasicTest [3824:2780:1220/111332:4747750:FATAL:statistics_recorder.cc(270)] Check failed: !histograms_. TBR=lpromero@chromium.org > Reland "Add a HistogramRecorder class and use cases." > > This CL adds a utility class to streamline the task of testing that metrics have been updated as expected. Specifically, the HistogramRecorder class allows a client to obtain the differential value of a given histogram in the interval since the given HistogramRecorder instance was created. > > This reverts commit b957026f43ef9464a8cdd5a240867c807b2281da. > > BUG=232414 > TBR=rsleevi, mark, groby, thakis > > Review URL: https://codereview.chromium.org/19866004 TBR=lpromero@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -205 lines) Patch
M trunk/src/base/base.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/base/metrics/statistics_recorder.h View 1 chunk +3 lines, -3 lines 0 comments Download
D trunk/src/base/test/histogram_recorder.h View 1 chunk +0 lines, -44 lines 0 comments Download
D trunk/src/base/test/histogram_recorder.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D trunk/src/base/test/histogram_recorder_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M trunk/src/chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc View 4 chunks +68 lines, -36 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/browser/password_generation_bubble_controller_unittest.mm View 6 chunks +27 lines, -8 lines 0 comments Download
M trunk/src/net/url_request/url_request_throttler_unittest.cc View 6 chunks +64 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
groby-ooo-7-16
7 years ago (2013-12-20 21:13:26 UTC) #1
groby-ooo-7-16
Committed patchset #1 manually as r242176.
7 years ago (2013-12-20 21:14:24 UTC) #2
lpromero
7 years ago (2013-12-23 09:27:22 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698