chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h - Issue 1202713002: Replace enhanced bookmarks salient images with favicons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h

Issue 1202713002: Replace enhanced bookmarks salient images with favicons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Line wraps in EnhanacedBookmarkItem.java Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/enhanced_bookmarks/android/enhanced_bookmark_tab_helper.cc ('k') | chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h

diff --git a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h

index a8844cb4eb9ef694b5fc5ec02436f065818fa74d..007fa568ad5ddc636a7353c9bc5338dcbfed8768 100644

--- a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h

+++ b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h

@@ -22,13 +22,6 @@ class EnhancedBookmarksBridge {

EnhancedBookmarksBridge(JNIEnv* env, jobject obj, Profile* profile);

void Destroy(JNIEnv*, jobject);

- void SalientImageForUrl(JNIEnv* env,

- jobject obj,

- jstring j_url,

- jobject j_callback);

- void FetchImageForTab(JNIEnv* env, jobject obj, jobject j_web_contents);

base::android::ScopedJavaLocalRef<jobject> AddFolder(JNIEnv* env,

jobject obj,

jobject j_parent_id_obj,

@@ -53,7 +46,6 @@ class EnhancedBookmarksBridge {

JavaObjectWeakGlobalRef weak_java_ref_;

EnhancedBookmarkModel* enhanced_bookmark_model_; // weak

- BookmarkImageServiceAndroid* bookmark_image_service_; // weak

Profile* profile_; // weak

DISALLOW_COPY_AND_ASSIGN(EnhancedBookmarksBridge);

};