Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1867)

Unified Diff: chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

Issue 1202713002: Replace enhanced bookmarks salient images with favicons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Line wraps in EnhanacedBookmarkItem.java Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h
diff --git a/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h b/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h
deleted file mode 100644
index ca47f92ca2aed0c76a11286e17be2f6ab3c5b568..0000000000000000000000000000000000000000
--- a/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h
+++ /dev/null
@@ -1,111 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_ENHANCED_BOOKMARKS_ANDROID_BOOKMARK_IMAGE_SERVICE_ANDROID_H_
-#define CHROME_BROWSER_ENHANCED_BOOKMARKS_ANDROID_BOOKMARK_IMAGE_SERVICE_ANDROID_H_
-
-#include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"
-#include "components/enhanced_bookmarks/bookmark_image_service.h"
-#include "content/public/common/referrer.h"
-
-namespace chrome {
-class BitmapFetcher;
-}
-
-namespace content {
-class BrowserContext;
-class RenderFrameHost;
-class WebContents;
-}
-
-namespace enhanced_bookmarks {
-
-class BookmarkImageServiceAndroid : public BookmarkImageService {
- public:
- explicit BookmarkImageServiceAndroid(content::BrowserContext* browserContext);
-
- ~BookmarkImageServiceAndroid() override;
-
- void RetrieveSalientImage(const GURL& page_url,
- const GURL& image_url,
- const std::string& referrer,
- net::URLRequest::ReferrerPolicy referrer_policy,
- bool update_bookmark) override;
-
- // Searches the current page for a salient image, if a url is found the image
- // is fetched and stored.
- void RetrieveSalientImageFromContext(
- content::WebContents* web_contents,
- const GURL& page_url,
- bool update_bookmark);
-
- // Investigates if the tab points to a bookmarked url in needs of an updated
- // image. If it is, invokes RetrieveSalientImageFromContext() for the relevant
- // urls.
- void FinishSuccessfulPageLoadForTab(content::WebContents* web_contents,
- bool update_bookmark);
-
- private:
- // The callback for dom_initializer_script_. Once the DOM is initialized,
- // this method starts execution of get_salient_image_url_script_.
- void InitializeDomCallback(blink::WebReferrerPolicy policy,
- content::RenderFrameHost* render_frame_host,
- const GURL& page_url,
- bool update_bookmark,
- const base::Value* result);
-
- // The callback for get_salient_image_url_srcipt. Parses the JSON from
- // execution of get_salient_image_url_script_ to determine the URL for the
- // salient image and invokes RetrieveSalientImage.
- void RetrieveSalientImageFromContextCallback(blink::WebReferrerPolicy policy,
- const GURL& page_url,
- bool update_bookmark,
- const base::Value* result);
-
- scoped_ptr<gfx::Image> ResizeImage(const gfx::Image& image) override;
-
- content::BrowserContext* browser_context_;
-
- // The script injected in a page to initialize the DOM before extracting image
- // urls.
- base::string16 dom_initializer_script_;
-
- // The script injected in a page to extract image urls.
- base::string16 get_salient_image_url_script_;
-
- // Maximum size for retrieved salient images in pixels. This is used when
- // resizing an image.
- gfx::Size max_size_;
-
- class BitmapFetcherHandler : private chrome::BitmapFetcherDelegate {
- public:
- explicit BitmapFetcherHandler(BookmarkImageServiceAndroid* service,
- const GURL& image_url)
- : service_(service), bitmap_fetcher_(image_url, this) {}
- void Start(content::BrowserContext* browser_context,
- const std::string& referrer,
- net::URLRequest::ReferrerPolicy referrer_policy,
- int load_flags,
- bool update_bookmark,
- const GURL& page_url);
- void OnFetchComplete(const GURL& url, const SkBitmap* bitmap) override;
-
- protected:
- ~BitmapFetcherHandler() override {}
-
- private:
- BookmarkImageServiceAndroid* service_;
- chrome::BitmapFetcher bitmap_fetcher_;
- bool update_bookmark_;
- GURL page_url_;
-
- DISALLOW_COPY_AND_ASSIGN(BitmapFetcherHandler);
- };
-
- DISALLOW_COPY_AND_ASSIGN(BookmarkImageServiceAndroid);
-};
-
-} // namespace enhanced_bookmarks
-
-#endif // CHROME_BROWSER_ENHANCED_BOOKMARKS_ANDROID_BOOKMARK_IMAGE_SERVICE_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698