chrome/BUILD.gn - Issue 1202713002: Replace enhanced bookmarks salient images with favicons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1202713002: Replace enhanced bookmarks salient images with favicons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add chrome_browser_bookmark_android_sources back to chrome/browser/BUILD.gn Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/res/layout/eb_item.xml » ('j') | chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkItem.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index e33713bf94c745c2767db64c1421567aae53ea12..271893686394b1b45985565852129fa2f6c810eb 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -566,11 +566,6 @@ repack("packed_extra_resources") {

} else {

output = "$root_out_dir/resources.pak"

}

- if (is_android) {

- sources += [ "$root_gen_dir/components/resources/enhanced_bookmarks/enhanced_bookmarks_resources.pak" ]

- deps += [ "//components/resources/enhanced_bookmarks:enhanced_bookmarks_resources" ]

- }

}

# GYP version: chrome/chrome_resources.gyp:browser_tests_pak