Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc

Issue 1202713002: Replace enhanced bookmarks salient images with favicons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Line wraps in EnhanacedBookmarkItem.java Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h" 5 #include "chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h"
6 6
7 #include "base/android/jni_array.h" 7 #include "base/android/jni_array.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "chrome/browser/enhanced_bookmarks/android/bookmark_image_service_andro id.h"
11 #include "chrome/browser/enhanced_bookmarks/android/bookmark_image_service_facto ry.h"
12 #include "chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.h" 10 #include "chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.h"
13 #include "chrome/browser/profiles/profile_android.h" 11 #include "chrome/browser/profiles/profile_android.h"
14 #include "chrome/common/chrome_version_info.h" 12 #include "chrome/common/chrome_version_info.h"
15 #include "chrome/common/pref_names.h" 13 #include "chrome/common/pref_names.h"
16 #include "components/bookmarks/browser/bookmark_utils.h" 14 #include "components/bookmarks/browser/bookmark_utils.h"
17 #include "components/bookmarks/common/android/bookmark_id.h" 15 #include "components/bookmarks/common/android/bookmark_id.h"
18 #include "components/bookmarks/common/android/bookmark_type.h" 16 #include "components/bookmarks/common/android/bookmark_type.h"
19 #include "content/public/browser/browser_thread.h" 17 #include "content/public/browser/browser_thread.h"
20 #include "content/public/browser/web_contents.h" 18 #include "content/public/browser/web_contents.h"
21 #include "jni/EnhancedBookmarksBridge_jni.h" 19 #include "jni/EnhancedBookmarksBridge_jni.h"
22 #include "ui/gfx/android/java_bitmap.h" 20 #include "ui/gfx/android/java_bitmap.h"
23 21
24 using base::android::AttachCurrentThread; 22 using base::android::AttachCurrentThread;
25 using base::android::ScopedJavaGlobalRef; 23 using base::android::ScopedJavaGlobalRef;
26 using bookmarks::android::JavaBookmarkIdCreateBookmarkId; 24 using bookmarks::android::JavaBookmarkIdCreateBookmarkId;
27 using bookmarks::android::JavaBookmarkIdGetId; 25 using bookmarks::android::JavaBookmarkIdGetId;
28 using bookmarks::android::JavaBookmarkIdGetType; 26 using bookmarks::android::JavaBookmarkIdGetType;
29 using bookmarks::BookmarkNode; 27 using bookmarks::BookmarkNode;
30 using bookmarks::BookmarkType; 28 using bookmarks::BookmarkType;
31 using content::WebContents; 29 using content::WebContents;
32 using content::BrowserThread; 30 using content::BrowserThread;
33 using enhanced_bookmarks::ImageRecord;
34
35 namespace {
36
37 void Callback(ScopedJavaGlobalRef<jobject>* j_callback,
38 scoped_refptr<ImageRecord> image_record) {
39 JNIEnv* env = base::android::AttachCurrentThread();
40
41 scoped_ptr<ScopedJavaGlobalRef<jobject> > j_callback_ptr(j_callback);
42 ScopedJavaLocalRef<jstring> j_url =
43 base::android::ConvertUTF8ToJavaString(env, image_record->url.spec());
44
45 SkBitmap bitmap = image_record->image->AsBitmap();
46 ScopedJavaLocalRef<jobject> j_bitmap;
47 if (!bitmap.isNull()) {
48 j_bitmap = gfx::ConvertToJavaBitmap(&bitmap);
49 }
50
51 enhanced_bookmarks::android::Java_SalientImageCallback_onSalientImageReady(
52 env, j_callback_ptr->obj(), j_bitmap.Release(), j_url.Release());
53 }
54
55 } // namespace
56 31
57 namespace enhanced_bookmarks { 32 namespace enhanced_bookmarks {
58 namespace android { 33 namespace android {
59 34
60 EnhancedBookmarksBridge::EnhancedBookmarksBridge(JNIEnv* env, 35 EnhancedBookmarksBridge::EnhancedBookmarksBridge(JNIEnv* env,
61 jobject obj, 36 jobject obj,
62 Profile* profile) : weak_java_ref_(env, obj) { 37 Profile* profile) : weak_java_ref_(env, obj) {
63 profile_ = profile; 38 profile_ = profile;
64 enhanced_bookmark_model_ = 39 enhanced_bookmark_model_ =
65 EnhancedBookmarkModelFactory::GetForBrowserContext(profile_); 40 EnhancedBookmarkModelFactory::GetForBrowserContext(profile_);
66 enhanced_bookmark_model_->SetVersionSuffix(chrome::VersionInfo().OSType()); 41 enhanced_bookmark_model_->SetVersionSuffix(chrome::VersionInfo().OSType());
67 bookmark_image_service_ = static_cast<BookmarkImageServiceAndroid*>(
68 BookmarkImageServiceFactory::GetForBrowserContext(profile_));
69 } 42 }
70 43
71 void EnhancedBookmarksBridge::Destroy(JNIEnv*, jobject) { 44 void EnhancedBookmarksBridge::Destroy(JNIEnv*, jobject) {
72 delete this; 45 delete this;
73 } 46 }
74 47
75 void EnhancedBookmarksBridge::SalientImageForUrl(JNIEnv* env,
76 jobject obj,
77 jstring j_url,
78 jobject j_callback) {
79 DCHECK(j_callback);
80
81 GURL url(base::android::ConvertJavaStringToUTF16(env, j_url));
82 scoped_ptr<ScopedJavaGlobalRef<jobject>> j_callback_ptr(
83 new ScopedJavaGlobalRef<jobject>());
84 j_callback_ptr->Reset(env, j_callback);
85 bookmark_image_service_->SalientImageForUrl(
86 url, base::Bind(&Callback, j_callback_ptr.release()));
87 }
88
89 void EnhancedBookmarksBridge::FetchImageForTab(JNIEnv* env,
90 jobject obj,
91 jobject j_web_contents) {
92 WebContents* web_contents = WebContents::FromJavaWebContents(j_web_contents);
93 bookmark_image_service_->RetrieveSalientImageFromContext(
94 web_contents, web_contents->GetURL(), true);
95 }
96
97 ScopedJavaLocalRef<jobject> EnhancedBookmarksBridge::AddFolder(JNIEnv* env, 48 ScopedJavaLocalRef<jobject> EnhancedBookmarksBridge::AddFolder(JNIEnv* env,
98 jobject obj, 49 jobject obj,
99 jobject j_parent_id_obj, 50 jobject j_parent_id_obj,
100 jint index, 51 jint index,
101 jstring j_title) { 52 jstring j_title) {
102 DCHECK(enhanced_bookmark_model_->loaded()); 53 DCHECK(enhanced_bookmark_model_->loaded());
103 long bookmark_id = JavaBookmarkIdGetId(env, j_parent_id_obj); 54 long bookmark_id = JavaBookmarkIdGetId(env, j_parent_id_obj);
104 const BookmarkNode* parent = bookmarks::GetBookmarkNodeByID( 55 const BookmarkNode* parent = bookmarks::GetBookmarkNodeByID(
105 enhanced_bookmark_model_->bookmark_model(), 56 enhanced_bookmark_model_->bookmark_model(),
106 static_cast<int64>(bookmark_id)); 57 static_cast<int64>(bookmark_id));
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 return reinterpret_cast<jlong>(new EnhancedBookmarksBridge( 130 return reinterpret_cast<jlong>(new EnhancedBookmarksBridge(
180 env, obj, ProfileAndroid::FromProfileAndroid(j_profile))); 131 env, obj, ProfileAndroid::FromProfileAndroid(j_profile)));
181 } 132 }
182 133
183 bool RegisterEnhancedBookmarksBridge(JNIEnv* env) { 134 bool RegisterEnhancedBookmarksBridge(JNIEnv* env) {
184 return RegisterNativesImpl(env); 135 return RegisterNativesImpl(env);
185 } 136 }
186 137
187 } // namespace android 138 } // namespace android
188 } // namespace enhanced_bookmarks 139 } // namespace enhanced_bookmarks
OLDNEW
« no previous file with comments | « chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698