Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: Source/bindings/core/v8/V8PerContextData.cpp

Issue 1202683002: bindings: Supports per-member [Exposed] for attributes on prototype. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8DOMConfiguration.cpp ('k') | Source/bindings/core/v8/WrapperTypeInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8PerContextData.cpp
diff --git a/Source/bindings/core/v8/V8PerContextData.cpp b/Source/bindings/core/v8/V8PerContextData.cpp
index cd10443f0d862a3c160ceaa0607c1e4d0ebc5d04..70b3102a6cf215222e8283d6de0eff5cb0de0dc5 100644
--- a/Source/bindings/core/v8/V8PerContextData.cpp
+++ b/Source/bindings/core/v8/V8PerContextData.cpp
@@ -93,7 +93,7 @@ v8::Local<v8::Function> V8PerContextData::constructorForTypeSlowCase(const Wrapp
v8::Local<v8::Context> currentContext = context();
v8::Context::Scope scope(currentContext);
- // We shouldn't reach this point for the types that are implemented in v8 suche as typed arrays and
+ // We shouldn't reach this point for the types that are implemented in v8 such as typed arrays and
// hence don't have domTemplateFunction.
ASSERT(type->domTemplateFunction);
v8::Local<v8::FunctionTemplate> functionTemplate = type->domTemplate(m_isolate);
@@ -114,7 +114,7 @@ v8::Local<v8::Function> V8PerContextData::constructorForTypeSlowCase(const Wrapp
if (prototypeObject->InternalFieldCount() == v8PrototypeInternalFieldcount
&& type->wrapperTypePrototype == WrapperTypeInfo::WrapperTypeObjectPrototype)
prototypeObject->SetAlignedPointerInInternalField(v8PrototypeTypeIndex, const_cast<WrapperTypeInfo*>(type));
- type->preparePrototypeObject(m_isolate, prototypeObject);
+ type->preparePrototypeObject(m_isolate, prototypeObject, functionTemplate);
if (type->wrapperTypePrototype == WrapperTypeInfo::WrapperTypeExceptionPrototype) {
if (!v8CallBoolean(prototypeObject->SetPrototype(currentContext, m_errorPrototype.newLocal(m_isolate))))
return v8::Local<v8::Function>();
« no previous file with comments | « Source/bindings/core/v8/V8DOMConfiguration.cpp ('k') | Source/bindings/core/v8/WrapperTypeInfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698