Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 1202683002: bindings: Supports per-member [Exposed] for attributes on prototype. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_interface.py
diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py
index 0ecfb2b32ad236a47cb9071aadb403ab980f247e..e083b0bd6b374ae64e791d65ad59321550654cd5 100644
--- a/Source/bindings/scripts/v8_interface.py
+++ b/Source/bindings/scripts/v8_interface.py
@@ -298,7 +298,6 @@ def interface_context(interface):
attribute['runtime_enabled_function'])
and attribute['should_be_exposed_to_script']
for attribute in attributes),
- 'has_conditional_attributes': has_conditional_attributes,
'has_constructor_attributes': any(attribute['constructor_type'] for attribute in attributes),
'has_replaceable_attributes': any(attribute['is_replaceable'] for attribute in attributes),
})
@@ -560,6 +559,24 @@ def interface_context(interface):
'methods': methods,
})
+ # Conditionally enabled members
+ has_conditional_attributes_on_instance = any(
+ attribute['exposed_test'] and attribute['on_instance']
+ for attribute in attributes)
+ has_conditional_attributes_on_prototype = any(
+ attribute['exposed_test'] and attribute['on_prototype']
+ for attribute in attributes)
+ context.update({
+ 'has_conditional_attributes_on_instance':
+ has_conditional_attributes_on_instance,
+ 'has_conditional_attributes_on_prototype':
+ has_conditional_attributes_on_prototype,
+ 'has_conditional_member_on_prototype': (
+ unscopeables or
bashi 2015/06/23 08:21:03 It seems that |unscopeables| do nothing with condi
Yuki 2015/06/23 08:36:05 Good catch! Done.
+ conditionally_enabled_methods or
+ has_conditional_attributes_on_prototype),
+ })
+
context.update({
'indexed_property_getter': property_getter(interface.indexed_property_getter, ['index']),
'indexed_property_setter': property_setter(interface.indexed_property_setter, interface),

Powered by Google App Engine
This is Rietveld 408576698