Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(101)

Issue 1202633007: Add UseCounter for navigator.vibrate() (Closed)

Created:
4 years, 10 months ago by Michael van Ouwerkerk
Modified:
4 years, 10 months ago
Reviewers:
felt, dcheng
CC:
blink-reviews, felt, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add UseCounter for navigator.vibrate() Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197816

Patch Set 1 #

Patch Set 2 : Also count subframe usage. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/vibration/NavigatorVibration.cpp View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Michael van Ouwerkerk
Daniel, please take a look as core/frame owner.
4 years, 10 months ago (2015-06-23 17:05:49 UTC) #2
Michael van Ouwerkerk
Adrienne: FYI as we discussed adding this.
4 years, 10 months ago (2015-06-23 17:06:23 UTC) #3
dcheng
lgtm
4 years, 10 months ago (2015-06-23 18:00:25 UTC) #4
felt
Would it be useful to count iframes vs top level frames with separate counters?
4 years, 10 months ago (2015-06-23 18:09:44 UTC) #6
Michael van Ouwerkerk
On 2015/06/23 18:09:44, felt wrote: > Would it be useful to count iframes vs top ...
4 years, 10 months ago (2015-06-24 10:49:25 UTC) #7
felt
lgtm
4 years, 10 months ago (2015-06-24 13:51:21 UTC) #8
dcheng
still lgtm
4 years, 10 months ago (2015-06-24 20:09:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202633007/20001
4 years, 10 months ago (2015-06-25 10:18:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202633007/40001
4 years, 10 months ago (2015-06-25 10:23:57 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 12:15:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197816

Powered by Google App Engine
This is Rietveld 408576698