Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 120263006: Avoid any race conditions with RenderFrame getting notified that it's prerendering. (Closed)

Created:
6 years, 11 months ago by jam
Modified:
6 years, 11 months ago
Reviewers:
tburkard
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Avoid any race conditions with RenderFrame getting notified that it's prerendering. Originally PrerenderHelper was per RenderView. In r239860 I switched it to be per RenderFrame. Before PrerenderHelper was guaranteed to get the IPC telling it that it's prerendering before any navigation. After the change, the RenderFrame could be navigated by its parent frame before it gets the IPC that it's prerendering. This change ensures that there are no races by having a child frame check with its parent frame if it's pre-rendering at construction. We haven't yet turned on RenderFrame per frame, but this is something could happen once we do. BUG=304341 R=tburkard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243093

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
6 years, 11 months ago (2013-12-30 16:01:46 UTC) #1
tburkard
6 years, 11 months ago (2014-01-06 10:00:20 UTC) #2
lgtm

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698