Issue 12026032: Adding supported checks & test for SpeechRecognition APIs.

Issue 12026032: Adding supported checks & test for SpeechRecognition APIs. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding supported checks & test for SpeechRecognition APIs. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17420

Patch Set 4 : Changing event type constructor. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -14 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		8 chunks	+38 lines, -5 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		7 chunks	+32 lines, -2 lines	0 comments	Download
M	tests/html/html.status	View		5 chunks	+5 lines, -0 lines	0 comments	Download
A	tests/html/speechrecognition_test.dart	View	1 2 3	1 chunk	+43 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A +	tools/dom/templates/html/dart2js/impl_SpeechRecognition.darttemplate	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Event.darttemplate	View	1 2 3	1 chunk	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/12026032/diff/1001/tests/html/speechrecognition_test.dart File tests/html/speechrecognition_test.dart (right): https://codereview.chromium.org/12026032/diff/1001/tests/html/speechrecognition_test.dart#newcode30 tests/html/speechrecognition_test.dart:30: document.$dom_createEvent('SpeechRecognitionEvent'); can we make this test a little more ...

7 years, 11 months ago (2013-01-19 01:24:58 UTC) #2

blois

7 years, 11 months ago (2013-01-19 01:46:39 UTC) #4

https://codereview.chromium.org/12026032/diff/1001/tests/html/speechrecogniti...
File tests/html/speechrecognition_test.dart (right):

https://codereview.chromium.org/12026032/diff/1001/tests/html/speechrecogniti...
tests/html/speechrecognition_test.dart:30:
document.$dom_createEvent('SpeechRecognitionEvent');
On 2013/01/19 01:24:58, Emily Fortuna wrote:
> can we make this test a little more functional? 

Added a little more, but there isn't too much we can do with these since they
aren't really intended to be created manually.

This is essentially cloning what the event_test was doing for the events.

https://codereview.chromium.org/12026032/diff/1001/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_SpeechRecognition.darttemplate
(left):

https://codereview.chromium.org/12026032/diff/1001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_SpeechRecognition.darttemplate:10: factory
$CLASSNAME() => document.$dom_createRange();
On 2013/01/19 01:24:58, Emily Fortuna wrote:
> why get rid of the constructor? I thought using document.$dom_createEvent was
> probably a bad sign about our API...?

Diff is odd for this one, but I didn't remove the constructor for
SpeechRecognition, just patched it to work on dart2js.

We've been adding constructors to events which have init*Event calls, but the
SpeechRecognition ones do not. In general, I'm not sure that this is really
something we expect people to construct.

I added an Event.tag constructor to avoid the $dom_ calls, but for uncommon
types, I think we can avoid them similarly to uncommon HTML elements.

https://codereview.chromium.org/12026032/diff/1001/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_SpeechRecognition.darttemplate
(right):

https://codereview.chromium.org/12026032/diff/1001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_SpeechRecognition.darttemplate:7: 
On 2013/01/19 01:24:58, Emily Fortuna wrote:
> remove extra newline?

Done.

blois

Updated the Event.type constructor to also initialize the event.

7 years, 11 months ago (2013-01-22 17:53:27 UTC) #5

lgtm

Expand Messages | Collapse Messages