Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 12026020: Merge 175820 (Closed)

Created:
7 years, 11 months ago by digit1
Modified:
7 years, 11 months ago
Reviewers:
digit1
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

Merge 175820 > android: Pass CPU properties from browser to renderer process. > > This is necessary to allow the renderer processes to use NEON > instructions on ARM devices that support them in libraries like > Skia. > > The main issue is that on JellyBean and higher, the renderer > process runs in a sandbox that prevents it from accessing the > filesystem, including /proc/ which is the only way to query the > kernel for the features detected by the CPU. > > To overcome this, send the result of the probe to each renderer > process, which will use the new android_setCpu() function > introduced in https://gerrit.chromium.org/gerrit/#/c/39370/ > > Note that this requires that third-party libraries use the > android_getCpuCount() and android_getCpuFeatures() function > to get this data at runtime. > > BUG=164154 > NOTRY=true > > Review URL: https://chromiumcodereview.appspot.com/11503013 TBR=digit@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M base/android/base_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + base/android/cpu_features.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/android/cpu_features.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/android/java/src/org/chromium/base/CpuFeatures.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M base/base.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/android/sandboxed_process_service.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M content/content_app.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/SandboxedProcessService.java View 4 chunks +9 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
digit1
7 years, 11 months ago (2013-01-18 15:17:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698