content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 1202593002: Move browser-to-renderer opener plumbing to frame routing IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 1202593002: Move browser-to-renderer opener plumbing to frame routing IDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-create-opener-render-views

Patch Set: Remove suppress_opener Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc

index 4fc6640b860881e0fe4bfed4f4cd0f7179dc6e7c..977de0f1759cc37b4dc8f7c98590b76414a7ff4a 100644

--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc

@@ -1625,9 +1625,9 @@ TEST_F(RenderFrameHostManagerTest, CleanUpSwappedOutRVHOnProcessCrash) {

EXPECT_TRUE(

opener1_manager->GetSwappedOutRenderViewHost(rfh1->GetSiteInstance())

->IsRenderViewLive());

- EXPECT_EQ(opener1_manager->GetSwappedOutRenderViewHost(

- rfh1->GetSiteInstance())->GetRoutingID(),

- contents()->GetMainFrame()->GetRenderViewHost()->opener_route_id());

+ EXPECT_EQ(

+ opener1_manager->GetRoutingIdForSiteInstance(rfh1->GetSiteInstance()),

+ contents()->GetMainFrame()->GetRenderViewHost()->opener_frame_route_id());

}

// Test that RenderViewHosts created for WebUI navigations are properly

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »