content/public/test/test_renderer_host.h - Issue 1202593002: Move browser-to-renderer opener plumbing to frame routing IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/test_renderer_host.h

Issue 1202593002: Move browser-to-renderer opener plumbing to frame routing IDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-create-opener-render-views

Patch Set: More cleanup Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl_unittest.cc ('K') | « content/public/test/render_view_test.cc ('k') | content/renderer/render_view_impl.cc » ('j') | content/renderer/render_view_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/test_renderer_host.h

diff --git a/content/public/test/test_renderer_host.h b/content/public/test/test_renderer_host.h

index fc12cbebf65935a494dbfdd70b397d6d5275bdcd..c429876fc5b3e182b9655612a5ad173e6d60191b 100644

--- a/content/public/test/test_renderer_host.h

+++ b/content/public/test/test_renderer_host.h

@@ -132,12 +132,11 @@ class RenderViewHostTester {

virtual ~RenderViewHostTester() {}

// Gives tests access to RenderViewHostImpl::CreateRenderView.

- virtual bool CreateTestRenderView(

- const base::string16& frame_name,

- int opener_route_id,

- int proxy_routing_id,

- int32 max_page_id,

- bool created_with_opener) = 0;

+ virtual bool CreateTestRenderView(const base::string16& frame_name,

nasko 2015/07/07 16:26:21 Yuck, I've missed this in my patch to move frame n

+ int opener_frame_route_id,

+ int proxy_routing_id,

+ int32 max_page_id,

+ bool created_with_opener) = 0;

// Makes the WasHidden/WasShown calls to the RenderWidget that

// tell it it has been hidden or restored from having been hidden.