content/browser/renderer_host/render_view_host_impl.cc - Issue 1202593002: Move browser-to-renderer opener plumbing to frame routing IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 1202593002: Move browser-to-renderer opener plumbing to frame routing IDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-create-opener-render-views

Patch Set: More cleanup Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_manager.cc ('K') | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/site_per_process_browsertest.cc » ('j') | content/browser/site_per_process_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 08e220bde7322812df0dad094a7d10990a28fc75..c54e4e9dce2bc4305d2992a9ba2fd87f66c98991 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -274,7 +274,7 @@ SiteInstanceImpl* RenderViewHostImpl::GetSiteInstance() const {

}

bool RenderViewHostImpl::CreateRenderView(

- int opener_route_id,

+ int opener_frame_route_id,

int proxy_route_id,

int32 max_page_id,

const FrameReplicationState& replicated_frame_state,

@@ -316,7 +316,7 @@ bool RenderViewHostImpl::CreateRenderView(

params.session_storage_namespace_id =

delegate_->GetSessionStorageNamespace(instance_.get())->id();

// Ensure the RenderView sets its opener correctly.

- params.opener_route_id = opener_route_id;

+ params.opener_frame_route_id = opener_frame_route_id;

params.swapped_out = !is_active_;

params.replicated_frame_state = replicated_frame_state;

params.proxy_routing_id = proxy_route_id;