Move browser-to-renderer opener plumbing to frame routing IDs

content/browser/site_per_process_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/site_per_process_browsertest.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 2523 matching lines @@
       "      C = http://bar.com/\n"
       "      D = http://baz.com/",
       DepictFrameTree(popup_root));
 
   // Send a message from first subframe on main page to the first popup and
   // wait for a reply back. The reply verifies that the proxy for the opener
   // tab's subframe is targeted properly.
   PostMessageAndWaitForReply(root->child_at(0), "postToPopup('subframe-msg')",
                              "\"done-subframe1\"");
 
-  // TODO(alexmos): Once we propagate subframe opener information to new
-  // RenderViews, try sending a postMessage from the popup to window.opener and
-  // ensure that it reaches subframe1.
+  // Send a postMessage from the popup to window.opener and ensure that it
+  // reaches subframe1.  This verifies that the subframe opener information
+  // propagated to the popup's RenderViews.  Wait for subframe1 to send a reply

[nasko, 2015/07/07 16:26:21]

RenderViews? I thought we are tracking openers per frame now, no?

[alexmos, 2015/07/08 04:42:18]

Oops, fixed.

+  // message to the popup.
+  EXPECT_TRUE(ExecuteScript(popup->web_contents(), "window.name = 'popup';"));
+  PostMessageAndWaitForReply(popup_root, "postToOpener('subframe-msg', '*')",
+                             "\"done-popup\"");
 
-  // Verify the total number of received messages for each subframe.  First
-  // subframe and popup should have one message each, and other frames
-  // shouldn't have received any messages.
+  // Second a postMessage from popup2 to window.opener.opener, which should
+  // resolve to subframe1.  This tests opener chains of length greater than 1.
+  // As before, subframe1 will send a reply to popup2.
+  FrameTreeNode* popup2_root =
+      static_cast<WebContentsImpl*>(popup2->web_contents())
+          ->GetFrameTree()
+          ->root();
+  EXPECT_TRUE(ExecuteScript(popup2->web_contents(), "window.name = 'popup2';"));
+  PostMessageAndWaitForReply(popup2_root,
+                             "postToOpenerOfOpener('subframe-msg', '*')",
+                             "\"done-popup2\"");
+
+  // Verify the total number of received messages for each subframe:
+  //  - 3 for first subframe (two from first popup, one from second popup)
+  //  - 2 for popup (both from first subframe)
+  //  - 1 for popup2 (reply from first subframe)
+  //  - 0 for other frames
   EXPECT_EQ(0, GetReceivedMessages(root));
-  EXPECT_EQ(1, GetReceivedMessages(root->child_at(0)));
+  EXPECT_EQ(3, GetReceivedMessages(root->child_at(0)));
   EXPECT_EQ(0, GetReceivedMessages(root->child_at(1)));
-  EXPECT_EQ(1, GetReceivedMessages(popup_root));
+  EXPECT_EQ(2, GetReceivedMessages(popup_root));
+  EXPECT_EQ(1, GetReceivedMessages(popup2_root));
 }
 
 // Check that parent.frames[num] references correct sibling frames when the
 // parent is remote.  See https://crbug.com/478792.
 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, IndexedFrameAccess) {
   // Start on a page with three same-site subframes.
   GURL main_url(
       embedded_test_server()->GetURL("a.com", "/frame_tree/top.html"));
   EXPECT_TRUE(NavigateToURL(shell(), main_url));
 
@@ skipping 124 matching lines @@
       "   |--Site A\n"
       "   +--Site A\n"
       "        |--Site A\n"
       "        +--Site A\n"
       "             +--Site A\n"
       "Where A = http://127.0.0.1/",
       DepictFrameTree(root));
 }
 
 }  // namespace content